pwrliang commented on code in PR #735: URL: https://github.com/apache/sedona-db/pull/735#discussion_r3036918331
########## rust/sedona-spatial-join/src/index/spatial_index.rs: ########## Review Comment: `#[cfg(test)]` does not work cross-crate. We may resort to `#[allow(dead_code)]` ########## rust/sedona-spatial-join/src/index.rs: ########## Review Comment: Shall we also change the visibility to pub for `spatial_index` and `spatial_index_builder` as `SpatialIndex` trait has been declared as `pub` in this PR? ########## rust/sedona-spatial-join/src/lib.rs: ########## @@ -18,25 +18,25 @@ pub mod evaluated_batch; pub mod exec; mod index; Review Comment: We may expose `index` to `pub` ########## rust/sedona-spatial-join/src/index/spatial_index_builder.rs: ########## Review Comment: We may change the visiblity to `pub` or add some methods to update these variables, otherwise we cannot use `SpatialJoinBuildMetrics` out of the crate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
