james-willis commented on code in PR #749:
URL: https://github.com/apache/sedona-db/pull/749#discussion_r3030906598
##########
rust/sedona-raster-functions/src/rs_bandpath.rs:
##########
@@ -225,12 +218,18 @@ mod tests {
.downcast_ref::<StringArray>()
.expect("Expected StringArray");
- // Raster 0, band 1: OutDbRef -> URL
- assert_eq!(string_array.value(0), "s3://bucket/raster_0.tif");
- // Raster 1: null raster -> null
+ // Raster 0, band 1: OutDbRef → URI
+ assert_eq!(
+ string_array.value(0),
+ "geotiff://s3://bucket/raster_0.tif#band=1"
+ );
+ // Raster 1: null raster → null
assert!(string_array.is_null(1));
- // Raster 2, band 2: OutDbRef -> URL
- assert_eq!(string_array.value(2), "s3://bucket/raster_2.tif");
+ // Raster 2, band 2: OutDbRef → URI
+ assert_eq!(
+ string_array.value(2),
+ "geotiff://s3://bucket/raster_2.tif#band=3"
Review Comment:
need to think through the right behavior here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
