piyushka-ally opened a new pull request, #2771: URL: https://github.com/apache/sedona/pull/2771
## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/) ## Is this PR related to a ticket? - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #1496 ## What changes were proposed in this PR? The Sedona documentation website failed basic favicon validation (e.g. Real Favicon Generator checker) because it only had a single PNG favicon with no supporting assets or HTML meta tags. This PR adds all assets and tags required by modern browsers, iOS, Android, Windows, and Safari: - **`scripts/generate_favicons.py`** — new script that generates all favicon assets from `docs/image/sedona_logo_symbol.png` using Pillow. Includes alpha-channel tracing to produce a monochrome SVG for Safari pinned tabs. - **`Makefile`** — new `genfavicons` target; `pillow` added to the `docs` dependency group in `pyproject.toml`. - **Generated and committed to `docs/`**: `favicon.ico` (16×16, 32×32, 48×48), `favicon-16x16.png`, `favicon-32x32.png`, `apple-touch-icon.png` (180×180), `mstile-150x150.png`, `android-chrome-192x192.png`, `android-chrome-512x512.png`, `safari-pinned-tab.svg`, `site.webmanifest`, `browserconfig.xml`. - **`docs-overrides/main.html`** — adds `<link>` and `<meta>` tags for apple-touch-icon, PNG favicon sizes, web manifest, Safari mask-icon, msapplication tile, and theme-color. Uses the MkDocs `| url` filter for correct relative paths under mike versioning. - **`mkdocs.yml`** — changes `favicon:` to point to `favicon.ico`. To regenerate assets after a logo change: `make genfavicons`, then commit the output. ## How was this patch tested? - Verified all generated PNG dimensions and ICO frame sizes programmatically (16×16, 32×32, 48×48 in the ICO; correct pixel dimensions for all PNGs). - Confirmed `safari-pinned-tab.svg` is valid XML with `viewBox="0 0 100 100"` and monochrome `fill="#000000"`. - Confirmed `site.webmanifest` is valid JSON with relative icon paths (compatible with mike versioning). - Confirmed `browserconfig.xml` is valid XML. - Verified all HTML meta/link tags are present in the `extrahead` block. - Checked all text files pass pre-commit rules: correct Apache license header format, no trailing whitespace, final newlines, line lengths within Black's 88-char limit. ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
