Copilot commented on code in PR #723:
URL: https://github.com/apache/sedona-db/pull/723#discussion_r2944865237


##########
docs/index.md:
##########
@@ -39,6 +41,7 @@ SedonaDB is perfect for processing smaller to medium datasets 
on local machines
 * **Spatial query optimization**
     * Spatial-aware heuristic based optimization
     * Spatial-aware cost based optimization
+    * Automatic disk spilling for large-scale spatial joins

Review Comment:
   This PR is described as adding PyPI download badges, but this hunk also adds 
a new feature bullet (“Automatic disk spilling for large-scale spatial joins”). 
If this is intentional, the PR title/description should be updated; otherwise, 
please drop the unrelated documentation change to keep the PR scoped to badges.



##########
README.md:
##########
@@ -36,6 +38,7 @@ SedonaDB is perfect for processing smaller to medium datasets 
on local machines
 * **Spatial query optimization**
     * Spatial-aware heuristic based optimization
     * Spatial-aware cost based optimization
+    * Automatic disk spilling for large-scale spatial joins

Review Comment:
   This PR is described as adding PyPI download badges, but this change also 
adds an unrelated feature bullet (“Automatic disk spilling for large-scale 
spatial joins”). Please either remove this line from the PR or update the PR 
title/description to reflect the additional documentation change.



##########
docs/index.md:
##########
@@ -22,6 +22,8 @@ title: Introducing SedonaDB
   under the License.
 -->
 
+[![PyPI 
Version](https://img.shields.io/pypi/v/sedonadb)](https://pypi.org/project/sedonadb/)
 [![PyPI - 
Downloads](https://img.shields.io/pypi/dm/sedonadb)](https://pepy.tech/project/sedonadb)
 
[![Downloads](https://static.pepy.tech/personalized-badge/sedonadb?period=total&units=international_system&left_color=black&right_color=brightgreen&left_text=total%20downloads)](https://pepy.tech/project/sedonadb)
+

Review Comment:
   The new badges point to the `sedonadb` PyPI project, but this page’s 
installation instructions (and most other docs) recommend `pip install 
"apache-sedona[db]"`. This can confuse readers about which package/version the 
badges refer to. Please align the badges with the documented install path 
(e.g., use `apache-sedona` badges) or update the install instructions to match 
`sedonadb` if that’s now the canonical package name.



##########
README.md:
##########
@@ -19,6 +19,8 @@
 
 # SedonaDB
 
+[![PyPI 
Version](https://img.shields.io/pypi/v/sedonadb)](https://pypi.org/project/sedonadb/)
 [![PyPI - 
Downloads](https://img.shields.io/pypi/dm/sedonadb)](https://pepy.tech/project/sedonadb)
 
[![Downloads](https://static.pepy.tech/personalized-badge/sedonadb?period=total&units=international_system&left_color=black&right_color=brightgreen&left_text=total%20downloads)](https://pepy.tech/project/sedonadb)

Review Comment:
   These badges point to the `sedonadb` PyPI project, but later in this README 
the install instructions use `pip install "apache-sedona[db]"`. Please confirm 
which package you want to advertise and keep the badges and installation 
guidance consistent (either switch the badges to `apache-sedona` or adjust the 
install instructions to `sedonadb`).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to