pwrliang commented on code in PR #586: URL: https://github.com/apache/sedona-db/pull/586#discussion_r2820029223
########## c/sedona-libgpuspatial/src/libgpuspatial.rs: ########## @@ -0,0 +1,502 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::error::GpuSpatialError; +#[cfg(gpu_available)] +use crate::libgpuspatial_glue_bindgen::*; +use crate::predicate::GpuSpatialRelationPredicate; +use arrow_array::{Array, ArrayRef}; +use arrow_schema::ffi::FFI_ArrowSchema; +use arrow_schema::DataType; +use std::cell::UnsafeCell; +use std::convert::TryFrom; +use std::ffi::{c_void, CStr, CString}; +use std::os::raw::c_char; +use std::sync::Arc; + +pub struct GpuSpatialRuntimeWrapper { + runtime: UnsafeCell<GpuSpatialRuntime>, + /// Store which device the runtime is created on + pub device_id: i32, +} + +impl GpuSpatialRuntimeWrapper { + pub fn try_new( + device_id: i32, + ptx_root: &str, + use_cuda_memory_pool: bool, + cuda_memory_pool_init_precent: i32, + ) -> Result<GpuSpatialRuntimeWrapper, GpuSpatialError> { + let mut runtime = GpuSpatialRuntime { + init: None, + release: None, + get_last_error: None, + private_data: std::ptr::null_mut(), + }; + + unsafe { + GpuSpatialRuntimeCreate(&mut runtime); + } + + if let Some(init_fn) = runtime.init { + let c_ptx_root = CString::new(ptx_root).map_err(|_| { + GpuSpatialError::Init("Failed to convert ptx_root to CString".into()) + })?; + + let mut config = GpuSpatialRuntimeConfig { + device_id, + ptx_root: c_ptx_root.as_ptr(), + use_cuda_memory_pool, + cuda_memory_pool_init_precent, + }; + + unsafe { + let get_last_error = runtime.get_last_error; + let runtime_ptr = &mut runtime as *mut GpuSpatialRuntime; + + check_ffi_call( + move || init_fn(runtime_ptr as *mut _, &mut config), + get_last_error, + runtime_ptr, + GpuSpatialError::Init, + )?; + } + } else { + return Err(GpuSpatialError::Init("init function is None".to_string())); + } + + Ok(GpuSpatialRuntimeWrapper { + runtime: UnsafeCell::new(runtime), + device_id, + }) + } +} + +impl Drop for GpuSpatialRuntimeWrapper { + fn drop(&mut self) { + let runtime = self.runtime.get_mut(); + let release_fn = runtime.release.expect("release function is None"); + unsafe { + release_fn(runtime as *mut _); + } + } +} + +/// Internal wrapper that manages the lifecycle of the C `SedonaFloatIndex2D` struct. +/// It is wrapped in an `Arc` by the public structs to ensure thread safety. +struct FloatIndex2DWrapper { + index: SedonaFloatIndex2D, + // Keep a reference to the RT engine to ensure it lives as long as the index + _runtime: Arc<GpuSpatialRuntimeWrapper>, +} + +impl Drop for FloatIndex2DWrapper { + fn drop(&mut self) { + let release_fn = self.index.release.expect("release function is None"); + unsafe { + release_fn(&mut self.index as *mut _); + } + } +} + +pub struct FloatIndex2D { + inner: FloatIndex2DWrapper, +} + Review Comment: Should we also annotate the public interfaces (GpuSpatialIndex and GpuSpatialRefiner) with these traits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
