Copilot commented on code in PR #2048:
URL: https://github.com/apache/sedona/pull/2048#discussion_r2183329137
##########
python/sedona/geopandas/geoseries.py:
##########
@@ -468,10 +468,10 @@ def _to_geopandas(self) -> gpd.GeoSeries:
pd_series = self._to_internal_pandas()
try:
return gpd.GeoSeries(
- pd_series.map(lambda wkb: shapely.wkb.loads(bytes(wkb)))
+ pd_series.map(lambda wkb: shapely.wkb.loads(bytes(wkb))),
crs=self.crs
)
except Exception as e:
Review Comment:
[nitpick] Rather than catching all exceptions here, consider restricting to
shapely WKB loading errors (e.g., `WKBReadingError`) so other unexpected issues
aren’t silently hidden.
```suggestion
except shapely.errors.WKBReadingError:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
