Subham-KRLX commented on code in PR #2024:
URL: https://github.com/apache/sedona/pull/2024#discussion_r2173156973
##########
.pre-commit-config.yaml:
##########
@@ -70,6 +70,15 @@ repos:
- --license-filepath
- .github/workflows/license-templates/LICENSE.txt
- --fuzzy-match-generates-todo
+ - id: insert-license
Review Comment:
@james-willis Thank you for catching this - excellent observation! You're
absolutely right that pre-commit IDs should typically be unique.
The duplicate exists because:
1. We're applying the same license logic to both Java/Scala and now XML files
2. The hook configuration differs only in `files:` and `types:` parameters
I'm happy to:
- Rename this to `insert-license-xml` for clarity
- Or add a comment explaining the intentional duplication
Which would you prefer? I appreciate your guidance on this best practice
question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
