Kontinuation commented on issue #1996: URL: https://github.com/apache/sedona/issues/1996#issuecomment-2993352360
I reviewed the [s2geography](https://github.com/paleolimbot/s2geography) codebase we are porting, along with the related PR. There are several fundamental issues with the current approach to supporting geography queries: 1. s2geography implements geography predicates (intersects, containment checks, etc.) and distance computation by constructing `S2ShapeIndex` for various kinds of geography objects, and invokes `S2BooleanOperation` or `S2ClosestEdgeQuery` to do the heavy lifting. These algorithms were not ported to the latest `com.google.geometry:s2-geometry:2.0.0` release. 2. The master branch of [google/s2-geometry-library-java](https://github.com/google/s2-geometry-library-java) has these algorithms ported from C++ to Java, but there's no official release yet (https://github.com/google/s2-geometry-library-java/issues/40). Porting S2 algorithms we need such as `S2BooleanOperation` to our S2Geography implementation seems to be redundant effort, the ideal way is depending on a new release of the official s2-geometry java library. There might be breaking changes in the master branch, so this may affect other more fundamental works including basic Geography type implementations, WKT/WKB support, encoding/decoding, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
