jiayuasu commented on code in PR #1524: URL: https://github.com/apache/sedona/pull/1524#discussion_r1681824746
########## spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/RasterFunctions.scala: ########## @@ -0,0 +1,259 @@ +/* Review Comment: I suggest we should change the old implementation in place, instead of creating a new .Scala file for these special functions ########## docs/api/sql/Raster-operators.md: ########## @@ -452,14 +452,14 @@ SELECT RS_GeoReferrence(ST_MakeEmptyRaster(1, 3, 4, 100.0, 200.0,2.0, -3.0, 0.1, ### RS_GeoTransform -Introduction: Returns an array of parameters that represent the GeoTransformation of the raster. The array contains the following values: +Introduction: Returns a struct of parameters that represent the GeoTransformation of the raster. The struct has the following schema: -- 0: pixel width along west-east axis (x-axis) -- 1: pixel height along north-south axis (y-axis) -- 2: Rotation of the raster -- 3: Angular separation between x-axis and y-axis -- 4: X ordinate of upper-left coordinate -- 5: Y ordinate of upper-left coordinate +- magnitudeI: pixel width along west-east axis (x-axis) Review Comment: Why is this called `I` and `J`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
