szetszwo commented on code in PR #1425:
URL: https://github.com/apache/ratis/pull/1425#discussion_r3047112189
##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderBase.java:
##########
@@ -125,9 +125,13 @@ public void start() {
@Override
public boolean isRunning() {
return daemon.isWorking()
- && server.getInfo().isAlive()
- && server.getInfo().isLeader()
- && getRaftLog().isOpened();
+ && isLeaderReady();
+ }
+
+ private boolean isLeaderReady() {
+ return server.getInfo().isAlive()
+ && server.getInfo().isLeader()
+ && getRaftLog().isOpened();
}
Review Comment:
- Since we already have defined isLeaderReady(), which means that a new
leader has committed the first entry. Let's use a different name
`isLeaderAlive()` to avoid confusion.
- Also, please use 4 spaces for indentation. It really looks better in this
case.
```java
private boolean isLeaderAlive() {
return server.getInfo().isAlive()
&& server.getInfo().isLeader()
&& getRaftLog().isOpened();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
