[
https://issues.apache.org/jira/browse/RATIS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved RATIS-2437.
-------------------------------------
Fix Version/s: 3.3.0
3.2.2
Resolution: Fixed
> make_rc.sh version check prevents releasing subsequent RCs
> ----------------------------------------------------------
>
> Key: RATIS-2437
> URL: https://issues.apache.org/jira/browse/RATIS-2437
> Project: Ratis
> Issue Type: Improvement
> Reporter: Xinyu Tan
> Assignee: Xinyu Tan
> Priority: Major
> Fix For: 3.3.0, 3.2.2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Problem
> When running make_rc.sh 1-prepare-src to release subsequent RCs (e.g.,
> RC2), the ratis-bom version check fails:
> if ! git diff --name-only | grep -q ratis-bom/pom.xml; then
> echo 'ratis-bom not updated by `mvn versions:set`' >&2
> exit 1
> fi
> Root Cause
> This check was introduced in RATIS-2425 to ensure that mvn versions:set
> correctly updates the version in the ratis-bom module.
> However, when releasing RC2 or later, the version has already been set
> during the RC1 phase (e.g., from 3.3.0-SNAPSHOT to 3.3.0). When mvn
> versions:set -DnewVersion=3.3.0 is executed again, since the version does
> not change, ratis-bom/pom.xml will not be modified. Consequently, git diff
> will not detect any change in this file, causing the check to fail and
> terminate the release process.
> Impact
> - Unable to release RC2 and subsequent Release Candidates
> - Blocks the normal release workflow
> Proposed Change
> This is a chore change to remove the problematic version check logic from
> the release script. Version update verification should not rely on git diff
> detecting file changes, as this approach does not work when
> the version is already correctly set.
> Related Issue
> - RATIS-2425: make_rc.sh does not set version in ratis-bom
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
