leixm commented on code in PR #1285:
URL: https://github.com/apache/ratis/pull/1285#discussion_r2380686681
##########
ratis-common/src/main/java/org/apache/ratis/util/IOUtils.java:
##########
@@ -93,7 +94,7 @@ static <T> T getFromFuture(CompletableFuture<T> future,
Supplier<Object> name, T
static boolean shouldReconnect(Throwable e) {
return ReflectionUtils.isInstance(e,
SocketException.class, SocketTimeoutException.class,
ClosedChannelException.class, EOFException.class,
- AlreadyClosedException.class);
+ AlreadyClosedException.class, NettyRpcException.class);
Review Comment:
I have removed NettyRpcException, but we should call
`failOutstandingRequests(cause);` in exceptionCaught, and we should not wrap it
to IOException, because there may have been a SocketTimeoutException that
required reconnection, but because we wrapped it into an IOException, it
ultimately did not reconnect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
