huaxingao commented on code in PR #3915:
URL: https://github.com/apache/polaris/pull/3915#discussion_r2898320054
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/IdempotencyRecord.java:
##########
@@ -112,13 +112,12 @@ public String responseSummary() {
}
/**
- * Serialized representation of a small, whitelisted set of HTTP response
headers.
+ * Allowlisted snapshot of HTTP response headers to replay for duplicates.
*
- * <p>Stored as a JSON string so that the HTTP layer can replay key headers
(such as {@code
- * Content-Type}) when serving a duplicate idempotent request.
+ * <p>How this map is persisted is store-specific.
*/
@Override
- public String responseHeaders() {
+ public Map<String, String> responseHeaders() {
Review Comment:
For the headers we care about (default: just Content-Type), there's always
just one value, so getFirst is fine. If multi-valued header support is needed
later, we can change to Map<String, List<String>> in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
