sungwy opened a new pull request, #3940: URL: https://github.com/apache/polaris/pull/3940
<!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> Today, plain Java `Object` is used as the Path Lookup key in `PolarisResolutionManifest.getResolutionPath`. This poses a problem, because a Polaris Entity like `Namespace` or `PolicyIdentifier` could be used as the object key, or other aliases referring to the same object like `ResolverPath` or `PolarisSecurable` could also mistakenly be used as the object key, resulting in an unexpected cache miss in the `Resolver`. This PR standardizes the path look up key as `ResolverPathKey(List<String> entityNames, PolarisEntityType entityType)`, so that there is a consistent way to look up the same logical Polaris Entity, wherever in the code base we may be fetching the resolved Path. ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
