gh-yzou commented on code in PR #3826:
URL: https://github.com/apache/polaris/pull/3826#discussion_r2887547767


##########
spec/polaris-catalog-apis/generic-tables-api.yaml:
##########
@@ -256,6 +262,53 @@ components:
           items:
             $ref: 
'../iceberg-rest-catalog-open-api.yaml#/components/schemas/TableIdentifier'
 
+
+    StorageAccessCredential:

Review Comment:
   Based on the Iceberg thread 
(https://lists.apache.org/thread/44xfrnvoq5720cgjfnobnyp3xn1w8tvv
   ), it appears that, for historical reasons, Iceberg currently has 
overlapping configurations between StorageCredentials and config. Initializing 
a client requires merging both config and StorageCredentials.
   
   Following recent discussions in the Polaris thread 
(https://lists.apache.org/thread/9y0xnjfn4n06svkt657gcsplk6sc7dhf
   ), we have decided to simplify things in Polaris by maintaining a single 
configuration map that contains all necessary storage access configurations, 
and renaming StorageCredentials to StorageAccessConfig for clarity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to