flyingImer commented on code in PR #3896:
URL: https://github.com/apache/polaris/pull/3896#discussion_r2862071972
##########
polaris-core/src/main/java/org/apache/polaris/core/policy/PredefinedPolicyTypes.java:
##########
@@ -28,7 +28,8 @@ public enum PredefinedPolicyTypes implements PolicyType {
DATA_COMPACTION(0, "system.data-compaction", true),
METADATA_COMPACTION(1, "system.metadata-compaction", true),
ORPHAN_FILE_REMOVAL(2, "system.orphan-file-removal", true),
- SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true);
+ SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true),
+ TEST_NON_INHERITABLE(4, "system.test-non-inheritable", false);
Review Comment:
I'm skeptical about this impl - it leaks test infra into prod code
##########
polaris-core/src/main/java/org/apache/polaris/core/policy/PredefinedPolicyTypes.java:
##########
@@ -28,7 +28,8 @@ public enum PredefinedPolicyTypes implements PolicyType {
DATA_COMPACTION(0, "system.data-compaction", true),
METADATA_COMPACTION(1, "system.metadata-compaction", true),
ORPHAN_FILE_REMOVAL(2, "system.orphan-file-removal", true),
- SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true);
+ SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true),
+ TEST_NON_INHERITABLE(4, "system.test-non-inheritable", false);
Review Comment:
I'm skeptical about this impl - it leaks test infra into prod code.
Do we have other ways to exercise it? if not, can you update the PR
description on why this is the way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
