MonkeyCanCode commented on code in PR #168:
URL: https://github.com/apache/polaris-tools/pull/168#discussion_r2850936956
##########
console/docker/generate-config.sh:
##########
@@ -29,7 +29,11 @@ window.APP_CONFIG = {
VITE_POLARIS_REALM: '${VITE_POLARIS_REALM}',
VITE_POLARIS_PRINCIPAL_SCOPE: '${VITE_POLARIS_PRINCIPAL_SCOPE}',
VITE_OAUTH_TOKEN_URL: '${VITE_OAUTH_TOKEN_URL}',
- VITE_POLARIS_REALM_HEADER_NAME: '${VITE_POLARIS_REALM_HEADER_NAME}'
+ VITE_POLARIS_REALM_HEADER_NAME: '${VITE_POLARIS_REALM_HEADER_NAME}',
+ VITE_OIDC_ISSUER_URL: '${VITE_OIDC_ISSUER_URL}',
+ VITE_OIDC_CLIENT_ID: '${VITE_OIDC_CLIENT_ID}',
+ VITE_OIDC_REDIRECT_URI: '${VITE_OIDC_REDIRECT_URI}',
+ VITE_OIDC_SCOPE: '${VITE_OIDC_SCOPE}'
};
EOF
Review Comment:
nit: maybe worth adding a docker compose similar to
https://github.com/apache/polaris/blob/main/getting-started/keycloak/docker-compose.yml
so people can test this out a bit quicker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
