adutra commented on code in PR #3796:
URL: https://github.com/apache/polaris/pull/3796#discussion_r2845950744


##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -477,9 +477,14 @@ jobs:
           # Copy the updated index.yaml to the dist dev directory
           exec_process cp "$WORK_DIR/index.yaml" 
"${dist_dev_dir}/helm-chart/index.yaml"
 
-          # Commit the updated index
+          # Copy the artifacthub-repo.yml to the dist dev directory
+          exec_process cp "helm/polaris/artifacthub-repo.yml" 
"${dist_dev_dir}/helm-chart/artifacthub-repo.yml"
+
           exec_process cd "${dist_dev_dir}"
-          exec_process svn commit --username "$SVN_USERNAME" --password 
"$SVN_PASSWORD" --non-interactive -m "Update Helm index for 
${version_without_rc} RC${rc_number}"
+          # Add artifacthub-repo.yml if not already versioned
+          exec_process svn info helm-chart/artifacthub-repo.yml > /dev/null 
2>&1 || exec_process svn add helm-chart/artifacthub-repo.yml

Review Comment:
   This is only need to very first time we copy `artifacthub-repo.yml`.
   
   I wonder if we couldn't just do a manual `svn add` right now? This would 
simplify the release scripts a bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to