dennishuo commented on code in PR #3395: URL: https://github.com/apache/polaris/pull/3395#discussion_r2830981605
########## runtime/admin/src/main/java/org/apache/polaris/admintool/nosql/NoSqlCommand.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.admintool.nosql; + +import jakarta.inject.Inject; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceInfoCommand; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceLogCommand; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceRunCommand; +import org.apache.polaris.persistence.nosql.api.backend.Backend; +import picocli.CommandLine; + [email protected]( + name = "nosql", + subcommands = { + NoSqlMaintenanceInfoCommand.class, + NoSqlMaintenanceLogCommand.class, + NoSqlMaintenanceRunCommand.class, + }, + mixinStandardHelpOptions = true, + description = "Polaris NoSQL persistence.") +public class NoSqlCommand extends BaseNoSqlCommand { Review Comment: Just a question for my own understanding, since I'm not too familiar with how the command hierarchy works - how does this "sibling" command end up causing the nesting discussed on the dev list? It looks like the hierarchy is: NoSqlMaintenanceRunCommand extends BaseNoSqlMaintenanceCommand BaseNoSqlMaintenanceCommand extends BaseNoSqlCommand BaseNoSqlCommand extends BaseCommand While NoSqlCommand extends BaseNoSqlCommand Thus appears to be a "sibling" of `BaseNoSqlMaintenanceCommand ` rather than being a "parent". Some documentation on the expected full example commands would also be helpful to reason about this; could we add some to the PR description and/or readme/md docs? ########## runtime/admin/src/main/java/org/apache/polaris/admintool/nosql/NoSqlCommand.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.admintool.nosql; + +import jakarta.inject.Inject; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceInfoCommand; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceLogCommand; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceRunCommand; +import org.apache.polaris.persistence.nosql.api.backend.Backend; +import picocli.CommandLine; + [email protected]( + name = "nosql", + subcommands = { + NoSqlMaintenanceInfoCommand.class, + NoSqlMaintenanceLogCommand.class, + NoSqlMaintenanceRunCommand.class, + }, + mixinStandardHelpOptions = true, + description = "Polaris NoSQL persistence.") Review Comment: +1 to this rewording -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
