adutra commented on code in PR #3812:
URL: https://github.com/apache/polaris/pull/3812#discussion_r2830078568
##########
Makefile:
##########
@@ -287,6 +290,32 @@ helm-lint: check-dependencies ## Run Helm chart lint check
@ct lint --charts helm/polaris
@echo "--- Helm chart linting complete ---"
+helm-fixtures: DEPENDENCIES := kubectl
+.PHONY: helm-fixtures
+helm-fixtures: check-dependencies ## Create namespace and deploy fixtures for
Helm chart testing
+ @echo "--- Creating namespace and deploying fixtures ---"
+ @kubectl create namespace polaris --dry-run=client -o yaml | kubectl
apply -f -
+ @kubectl apply --namespace polaris -f helm/polaris/ci/fixtures/
+ @echo "--- Waiting for database pods to be ready ---"
+ @kubectl wait --namespace polaris --for=condition=ready pod
--selector=app.kubernetes.io/name=postgres --timeout=120s
+ @kubectl wait --namespace polaris --for=condition=ready pod
--selector=app.kubernetes.io/name=mongodb --timeout=120s
+ @echo "--- Fixtures deployed and ready ---"
+
+helm-fixtures-cleanup: DEPENDENCIES := kubectl
+.PHONY: helm-fixtures-cleanup
+helm-fixtures-cleanup: check-dependencies ## Remove fixtures and namespace for
Helm chart testing
+ @echo "--- Removing fixtures and namespace ---"
+ @kubectl delete --namespace polaris -f helm/polaris/ci/fixtures/
--ignore-not-found
+ @kubectl delete namespace polaris --ignore-not-found
Review Comment:
OK you convinced me 😄 – I changed all the sites where we were deleting the
namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
