snazy commented on PR #3797: URL: https://github.com/apache/polaris/pull/3797#issuecomment-3921941564
> Okay, so we can't remote this field, `SparkCatalogTest` will fail: > > ``` > Failed find the isUnityCatalog field, delta-spark version >= 3.2.1 is required > java.lang.RuntimeException: Failed find the isUnityCatalog field, delta-spark version >= 3.2.1 is required > at org.apache.polaris.spark.utils.DeltaHelper.loadDeltaCatalog(DeltaHelper.java:112) > at org.apache.polaris.spark.SparkCatalog.alterTable(SparkCatalog.java:196) > at org.apache.polaris.spark.SparkCatalogTest.testAlterAndRenameTable(SparkCatalogTest.java:559) > Caused by: java.lang.NoSuchFieldException: isUnityCatalog > at java.base/java.lang.Class.getDeclaredField(Class.java:2841) > at org.apache.polaris.spark.utils.DeltaHelper.loadDeltaCatalog(DeltaHelper.java:108) > ... 2 more > ``` > > It is used [here](https://github.com/apache/polaris/blob/main/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/DeltaHelper.java#L108), so although it seems unused, in fact it isn't. Bummer :( The comment's in the code base in not really helpful. Would you be open to update the comment with a more telling one and add some `@SuppressWarning` for that field? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
