dimas-b commented on code in PR #3757:
URL: https://github.com/apache/polaris/pull/3757#discussion_r2818836484
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java:
##########
@@ -24,7 +24,15 @@
import jakarta.annotation.Nullable;
import java.util.List;
-/** List of privileges */
+/**
+ * Enumerates the privileges used by the built-in RBAC authorizer ({@link
+ * org.apache.polaris.core.auth.PolarisAuthorizerImpl}). These privileges are
granted to roles and
+ * checked against securables during authorization.
Review Comment:
My point is that it is not self-evident to the reader of the java code. I do
not see links to Polaris' own site from code as particularly useful as code
will evolve independently from the site. I'd prefer a javadoc description or a
link to javadoc in another class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
