iting0321 commented on code in PR #3750:
URL: https://github.com/apache/polaris/pull/3750#discussion_r2805316648
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -1332,17 +1341,28 @@ private void checkAllowExternalCatalogCredentialVending(
* simple heuristics.
*
* @param requestedModes The set of delegation modes requested by the client
- * @return The resolved set of delegation modes (containing the single
optimal mode)
+ * @return The resolved access delegation mode
*/
- protected EnumSet<AccessDelegationMode> resolveAccessDelegationModes(
+ protected AccessDelegationMode resolveAccessDelegationModes(
EnumSet<AccessDelegationMode> requestedModes) {
if (requestedModes.isEmpty()) {
- return requestedModes;
+ resolvedAccessDelegationMode = AccessDelegationMode.UNKNOWN;
Review Comment:
I think NONE is more precise, since it clearly communicates that no
delegation mode was requested or selected. I’m happy to add it in a follow-up
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
