adutra commented on code in PR #3758:
URL: https://github.com/apache/polaris/pull/3758#discussion_r2805055393
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java:
##########
@@ -118,38 +118,5 @@ public abstract StorageAccessConfig getSubscopedCreds(
* Result of calling {@link #validateAccessToLocations(RealmConfig,
* PolarisStorageConfigurationInfo, Set, Set)}
*/
- public static final class ValidationResult {
- private final boolean success;
- private final String message;
-
- public ValidationResult(boolean success, String message) {
- this.success = success;
- this.message = message;
- }
-
- public boolean isSuccess() {
- return success;
- }
-
- public String getMessage() {
- return message;
- }
-
- @Override
- public boolean equals(Object o) {
Review Comment:
This was an interesting case: the equals/hashCode methods were considering
only `success`, not `message`. But this doesn't feel right.
Moreover, instances of this class are never compared, or added to sets or
map keys. The actual equals/hashCode implementation seems irrelevant.
It turns out, this equals/hashCode implementation was probably meant for
tests: some tests compare instances by ignoring the message.
I fixed the tests instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
