dimas-b opened a new pull request, #3753: URL: https://github.com/apache/polaris/pull/3753
Following up on #3735 * Consolidate property lookup (preference) logic in PolarisConfiguration * Consolidate property type cast logic in PolarisConfiguration (add case for `Float`) * Improve test coverage in PolarisConfigurationTest and RealmConfigImplTest * Remove irrelevant tests from PolarisConfigurationStoreTest and DefaultConfigurationStoreTest (covered by the above tests) This change does not affect configuration lookup behaviour aside from failures related to incorrect config for `Float` types... However, that case is apparently not invoked by existing `PolarisConfiguration` constants. <!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
