snazy commented on code in PR #3732: URL: https://github.com/apache/polaris/pull/3732#discussion_r2797829482
########## spec/generated/bundled-polaris-catalog-service.yaml: ########## Review Comment: I am a huge fan of automating "all the things" and let CI "catch all the things". As mentioned in my other comment, the process to update the OpenAPI is a very manual process in which people can easily miss those steps. I've been experimenting with a process to generate the OpenAPI spec from Java types, using the microprofile OpenAPI annotations with an additional check that verifies that the generated OpenAPI-yaml has no breaking changes against a reference OpenAPI-yaml. Starting from Java types has the advantage that there are no more manual steps needed. Currently, one has to update not just the spec but also a bunch of build scripts for most OpenAPI spec changes, leaking spec specific type names into build scripts. Thinking further, it is pretty much impossible to make REST endpoints work asynchronously/reactive, because the endpoint functions' signatures are dictated by the code generator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
