dimas-b commented on code in PR #3735: URL: https://github.com/apache/polaris/pull/3735#discussion_r2794315172
########## runtime/service/src/test/java/org/apache/polaris/service/config/DefaultConfigurationStoreTest.java: ########## Review Comment: The diff in this PR is pretty clear that `catalogConfigUnsafe` and `legacyCatalogConfig` work the same way, so existing tests apply to `legacyCatalogConfig` as well. I tend to agree that in general the testing of config lookup can be improved, I'd prefer to make it in a separate PR though and keep this PR as a "pure" refactoring. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
