dimas-b commented on code in PR #3681:
URL: https://github.com/apache/polaris/pull/3681#discussion_r2793952631
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java:
##########
@@ -908,4 +913,75 @@ public boolean hasTransitivePrivilege(
resolvedPath);
return false;
}
+
+ @Override
+ public void preAuthorize(
+ @Nonnull AuthorizationCallContext ctx, @Nonnull AuthorizationRequest
request) {
+ PolarisResolutionManifest manifest = ctx.getResolutionManifest();
+ if (manifest.hasResolution()) {
+ return;
+ }
Review Comment:
I'm fine with option 2.
Consistency guarantees in Persistence is a very hard topic because Polaris
supports pluggable (custom) Persistence. I wish we could have a precise
Persistence contract defined in code or docs, but I do not think we're
completely strict and well-defined on that side in the current state of the
repository :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
