PhillHenry commented on code in PR #3729: URL: https://github.com/apache/polaris/pull/3729#discussion_r2793839737
########## polaris-core/src/main/java/org/apache/polaris/core/connection/GcpAuthenticationParametersDpo.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.connection; + +import com.fasterxml.jackson.annotation.JsonProperty; +import jakarta.annotation.Nonnull; +import java.util.HashMap; +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.CatalogProperties; +import org.apache.iceberg.rest.auth.AuthProperties; +import org.apache.polaris.core.admin.model.AuthenticationParameters; +import org.apache.polaris.core.admin.model.GoogleAuthenticationParameters; +import org.apache.polaris.core.credentials.PolarisCredentialManager; + +/** + * See {@link org.apache.iceberg.rest.RESTUtil#configHeaders(Map)} and {@link + * org.apache.iceberg.rest.auth.AuthManagers#loadAuthManager(String, Map)} for why we do this. + */ +public class GoogleAuthenticationParametersDpo extends AuthenticationParametersDpo { + private final String clientId; + private final String quotaProject; + private final String remoteWarehouseName; + + public GoogleAuthenticationParametersDpo( + @JsonProperty(value = "clientId", required = true) @Nonnull String clientId, + @JsonProperty(value = "quotaProject", required = true) @Nonnull String quotaProject, + @JsonProperty(value = "remoteWarehouseName", required = true) @Nonnull + String remoteWarehouseName) { + super(AuthenticationType.GOOGLE.getCode()); + this.clientId = clientId; + this.quotaProject = quotaProject; + this.remoteWarehouseName = remoteWarehouseName; + } + + @Nonnull + @Override + public Map<String, String> asIcebergCatalogProperties( + PolarisCredentialManager credentialManager) { + HashMap<String, String> properties = new HashMap<>(); + properties.put("header.x-goog-user-project", getQuotaProject()); + properties.put("header.X-Iceberg-Access-Delegation", "vended-credentials"); Review Comment: Yes, that message is I believe from contacting a GCP endpoint. Shall I add a field to the new GcpAuthenticationParameters DTO to capture which CredentialMode value to use? My own personal BigLake endpoint is configured for CREDENTIAL_MODE_VENDED_CREDENTIALS_VALUE (hence the need for vended-credentials) even though the code uses the paradigm associated with CREDENTIAL_MODE_END_USER_VALUE. I anticipate another PR to implement the CREDENTIAL_MODE_VENDED_CREDENTIALS_VALUE paradigm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
