iting0321 commented on code in PR #3723:
URL: https://github.com/apache/polaris/pull/3723#discussion_r2791792795


##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##########
@@ -167,6 +170,11 @@ public Table createTable(
         // to create the .hoodie folder in cloud storage
         TableCatalog hudiCatalog = 
hudiHelper.loadHudiCatalog(this.polarisSparkCatalog);
         return hudiCatalog.createTable(ident, schema, transforms, properties);
+      } else if (PolarisCatalogUtils.usePaimon(provider)) {

Review Comment:
   I kept `usePaimon()` in `PolarisCatalogUtils` to remain consistent with the 
existing `useDelta()` and `useHudi()` methods. Moving these methods into their 
respective helpers could be a good follow-up refactor, but I preferred to keep 
this PR focused on the current scope.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to