dimas-b commented on code in PR #3722:
URL: https://github.com/apache/polaris/pull/3722#discussion_r2789748058


##########
integration-tests/src/main/java/org/apache/polaris/service/it/ext/PolarisIntegrationTestExtension.java:
##########
@@ -68,7 +68,7 @@ public Object resolveParameter(
   private Env env(ExtensionContext context) {
     ExtensionContext classCtx = classContext(context);
     ExtensionContext.Store store = classCtx.getStore(NAMESPACE);
-    return store.getOrComputeIfAbsent(
+    return store.computeIfAbsent(

Review Comment:
   This change is not required for Polaris to use JUnit 6. It is merely a 
deprecation warning fix in Polaris, but it forces downstream projects for 
switch to JUnit 6.
   
   Prior work (e.g. #391) makes me think that such use cases might exist 
outside the Quarkus build env. (and thus may not inherit JUnit 6).
   
   Whether this is still a relevant use case or not I cannot tell, but it might 
be worth keeping JUnit 5 compatibility for some more time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to