snazy commented on code in PR #3550:
URL: https://github.com/apache/polaris/pull/3550#discussion_r2782251253
##########
site/content/guides/minio/index.md:
##########
@@ -43,7 +56,7 @@ See the [Spark Notebooks Example](../spark/README.md) for a
more advanced Spark
2. Start the docker compose group by running the following command from the
root of the repository:
```shell
- docker compose -f getting-started/minio/docker-compose.yml up
+ docker compose -f site/content/guides/minio/docker-compose.yml up
Review Comment:
The assets are just kept next to the guides. I think it would be odd to
parts of one single guide scattered around different directory trees.
All guide pages refer to the ["Git clone"
here](https://github.com/apache/polaris/pull/3550/changes#diff-d8976c28f16aa0ff8995c26d21931204b0ee060f0a6bfda64ec64787e850e773R34).
We can certainly argue about why the guides assume that the repository root
and not the guide's directory is the current directory when running the guides.
I think, it would be more natural to assume the guide's directory as the
current one. I just refused to change that assumption in this PR. (That
assumption affects #3553, which builds on this PR.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
