jbonofre commented on code in PR #151:
URL: https://github.com/apache/polaris-tools/pull/151#discussion_r2779455190
##########
console/docker/Dockerfile:
##########
@@ -31,7 +31,7 @@ WORKDIR /app
COPY package.json ./
# Install dependencies
-RUN npm install
+RUN npm ci
Review Comment:
I think `install` is required before `ci`.
##########
console/Makefile:
##########
@@ -10,7 +10,7 @@ build-docker:
.PHONY: install
install:
- npm install
+ npm ci
Review Comment:
I think `install` is required before `ci`.
##########
console/vite.config.ts:
##########
@@ -29,4 +29,20 @@ export default defineConfig({
"@": path.resolve(__dirname, "./src"),
},
},
+ build: {
+ cssCodeSplit: false,
+ sourcemap: false,
+ rollupOptions: {
+ output: {
+ chunkFileNames: "assets/[name]-[hash].js",
+ entryFileNames: "assets/[name]-[hash].js",
+ assetFileNames: "assets/[name]-[hash][extname]",
+ manualChunks: (id) => {
+ if (id.includes("node_modules")) {
+ return "vendor"
Review Comment:
Do we really need that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
