tokoko commented on code in PR #3409:
URL: https://github.com/apache/polaris/pull/3409#discussion_r2777023634
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -105,6 +107,17 @@ public String serialize() {
}
}
+ public Optional<String> resolveStorageName() {
+ if (getAllowedLocations().isEmpty()) {
+ return Optional.empty();
+ }
+ try {
+ return Optional.ofNullable(new
URI(getAllowedLocations().get(0)).getHost());
Review Comment:
tbh, I was thinking maybe it would be better to instead scrap the whole uri
parsing here. My main reason for it is that I think it will be a headache to
build some sort of authorization solution on top unless storage names are
explicitly defined on the catalog config side. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
