dimas-b commented on code in PR #3385:
URL: https://github.com/apache/polaris/pull/3385#discussion_r2775335558


##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -315,6 +335,339 @@ public void writeEvents(@Nonnull List<PolarisEvent> 
events) {
     }
   }
 
+  /**
+   * Writes a scan metrics report to the database as a first-class entity.
+   *
+   * <p>This method requires schema version 4 or higher. On older schemas, 
this method is a no-op.
+   *
+   * @param report the scan metrics report to persist
+   */
+  public void writeScanMetricsReport(@Nonnull ModelScanMetricsReport report) {

Review Comment:
   Why not keep these methods in `JdbcMetricsPersistence`? 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to