obelix74 commented on code in PR #3616: URL: https://github.com/apache/polaris/pull/3616#discussion_r2766322366
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/metrics/ScanMetricsRecord.java: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.metrics; + +import java.time.Instant; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import org.apache.polaris.immutables.PolarisImmutable; + +/** + * Backend-agnostic representation of an Iceberg scan metrics report. + * + * <p>This record captures all relevant metrics from an Iceberg {@code ScanReport} along with + * contextual information such as realm, catalog, and request correlation data. + */ +@PolarisImmutable +public interface ScanMetricsRecord { + + // === Identification === + + /** Unique identifier for this report (UUID). */ + String reportId(); + + /** Multi-tenancy realm identifier. */ + String realmId(); + + /** Internal catalog ID. */ + String catalogId(); + + /** Human-readable catalog name. */ + String catalogName(); Review Comment: Agreed. I've updated the SPI to use separate namespace (String) and tableName (String) primitives instead of TableIdentifier. This avoids Iceberg dependencies in the Polaris SPI. The conversion from TableIdentifier to these primitives now happens in MetricsRecordConverter (in org.apache.polaris.core.metrics.iceberg package), where Iceberg dependencies are already present. Good point about catalog renames. I've removed catalogName from the SPI records and now store only catalogId. The query criteria (MetricsQueryCriteria) now uses catalogId (OptionalLong) instead of catalogName. For tables, I'm keeping namespace and tableName as strings rather than storing table entity IDs. While tables can also be renamed, users typically query metrics by table name rather than by internal entity ID. This is a pragmatic compromise - catalog renames are significant lifecycle events, while table renames within the same namespace are more routine and less likely to break historical queries. Let me know if you'd prefer to also use table entity IDs instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
