adnanhemani commented on code in PR #3456:
URL: https://github.com/apache/polaris/pull/3456#discussion_r2729520575
##########
runtime/service/src/main/java/org/apache/polaris/service/events/EventAttributes.java:
##########
@@ -108,7 +110,9 @@ private EventAttributes() {}
public static final AttributeKey<RenameTableRequest> RENAME_TABLE_REQUEST =
new AttributeKey<>("rename_table_request", RenameTableRequest.class);
public static final AttributeKey<LoadTableResponse> LOAD_TABLE_RESPONSE =
- new AttributeKey<>("load_table_response", LoadTableResponse.class);
+ new AttributeKey<>("load_table_responses", LoadTableResponse.class);
+ public static final AttributeKey<List<TableMetadata>> TABLE_METADATA =
+ new AttributeKey<>("table_metadatas", new
TypeToken<List<TableMetadata>>() {});
Review Comment:
Sure, I'm glad to do this. I was trying to make everything fit within
`TABLE_METADATAS` due to the similar comment that Dmitri had pointed out above.
But I will make a comment for this for now so we can move past and revisit if
there is a better way to do this later.
##########
runtime/service/src/main/java/org/apache/polaris/service/events/EventAttributes.java:
##########
@@ -108,7 +110,9 @@ private EventAttributes() {}
public static final AttributeKey<RenameTableRequest> RENAME_TABLE_REQUEST =
new AttributeKey<>("rename_table_request", RenameTableRequest.class);
public static final AttributeKey<LoadTableResponse> LOAD_TABLE_RESPONSE =
- new AttributeKey<>("load_table_response", LoadTableResponse.class);
+ new AttributeKey<>("load_table_responses", LoadTableResponse.class);
Review Comment:
Good catch, changed in the next revision.
##########
runtime/service/src/main/java/org/apache/polaris/service/events/EventAttributes.java:
##########
@@ -108,7 +110,9 @@ private EventAttributes() {}
public static final AttributeKey<RenameTableRequest> RENAME_TABLE_REQUEST =
new AttributeKey<>("rename_table_request", RenameTableRequest.class);
public static final AttributeKey<LoadTableResponse> LOAD_TABLE_RESPONSE =
- new AttributeKey<>("load_table_response", LoadTableResponse.class);
+ new AttributeKey<>("load_table_responses", LoadTableResponse.class);
+ public static final AttributeKey<List<TableMetadata>> TABLE_METADATA =
+ new AttributeKey<>("table_metadatas", new
TypeToken<List<TableMetadata>>() {});
Review Comment:
Sure.
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergRestCatalogEventServiceDelegator.java:
##########
@@ -345,15 +350,22 @@ public Response loadTable(
snapshots,
realmContext,
securityContext);
+
+ EventAttributeMap generatedEventAttributes =
Review Comment:
Good call out, was a hangover needed for a previous revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
