adutra commented on code in PR #3314:
URL: https://github.com/apache/polaris/pull/3314#discussion_r2672341763
##########
helm/polaris/templates/_helpers.tpl:
##########
@@ -89,6 +89,18 @@ app.kubernetes.io/name: {{ include "polaris.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end }}
+{{/*
+Validate that only one of ingress or httproute is enabled
+*/}}
+{{- define "polaris.validateRouting" -}}
+{{- if and .Values.ingress.enabled .Values.httproute.enabled }}
+{{- fail "Cannot enable both ingress and httproute. Please enable only one." }}
+{{- end }}
+{{- if and .Values.ingress.enabled (and (not .Values.httproute.enabled)
.Values.gateway.enabled) }}
Review Comment:
I think this should just test `and (not .Values.httproute.enabled)
.Values.gateway.enabled`, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
