snazy commented on code in PR #2543:
URL: https://github.com/apache/polaris/pull/2543#discussion_r2348470137
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/bootstrap/RootCredentialsSet.java:
##########
@@ -130,18 +137,29 @@ static RootCredentialsSet fromList(List<String>
credentialsList) {
* }
* </pre>
*/
- static RootCredentialsSet fromUrl(URL url) {
+ static RootCredentialsSet fromUri(URI uri) {
+ Preconditions.checkNotNull(uri);
+ Preconditions.checkArgument(
+ Strings.isNullOrEmpty(uri.getHost()),
+ "Remote URIs are not allowed for RootCredentialsSet: %s",
+ uri);
Review Comment:
Actually thinking a bit more about this, you can still get a "host" via a
`jar` URI like `jar:http://foo.bar/...` or all the `file` scheme "specialties".
But that's rather a question what source locations we want to allow.
For the scope of this PR, the change as it is looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
