XN137 commented on code in PR #2492:
URL: https://github.com/apache/polaris/pull/2492#discussion_r2318358984
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -2412,9 +2417,9 @@ private boolean sendNotificationForTableLike(
if (null == entity) {
existingLocation = null;
entity =
- new IcebergTableLikeEntity.Builder(tableIdentifier, newLocation)
+ new IcebergTableLikeEntity.Builder(
Review Comment:
good question, in this change i am just following the already existing code.
this method seems questionable in that it has a `PolarisEntitySubType`
parameter but also hardcodes `PolarisEntitySubType.ICEBERG_TABLE` in multiple
spots.
i guess it does not matter since this method is currently only ever called
from the `@Path("/namespaces/{namespace}/tables/{table}/notifications")` REST
handler (there is no equivalent for views afaict)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
