singhpk234 commented on code in PR #2485:
URL: https://github.com/apache/polaris/pull/2485#discussion_r2314833121
##########
persistence/relational-jdbc/src/main/resources/postgres/schema-v1.sql:
##########
@@ -21,7 +21,7 @@ SET search_path TO POLARIS_SCHEMA;
CREATE TABLE IF NOT EXISTS version (
version_key TEXT PRIMARY KEY,
- version_value INTEGER NOT NULL
+ version_value INT4 NOT NULL
Review Comment:
seems like cocroach-db uses pg driver as we have checks for the display type
here
https://github.com/apache/polaris/blob/main/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatabaseType.java#L46
would be nice to have a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
