dimas-b commented on code in PR #1844: URL: https://github.com/apache/polaris/pull/1844#discussion_r2308541095
########## runtime/service/src/main/java/org/apache/polaris/service/events/BeforeTableCommitedEvent.java: ########## @@ -26,10 +26,10 @@ * of this event relative to the validation checks we've performed, which means the commit may still * fail Polaris-side validation checks. * - * @param identifier The identifier. + * @param tableIdentifier The identifier. * @param base The old metadata. * @param metadata The new metadata. */ public record BeforeTableCommitedEvent( - TableIdentifier identifier, TableMetadata base, TableMetadata metadata) + String eventId, TableIdentifier tableIdentifier, TableMetadata base, TableMetadata metadata) Review Comment: +1 to `beforeMetadata` and afterMetadata`.. or `metadataBefore` / `metadataAfter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
