snazy commented on code in PR #2401:
URL: https://github.com/apache/polaris/pull/2401#discussion_r2288569817
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageToken.java:
##########
@@ -86,7 +87,10 @@ static PageToken fromLimit(int limit) {
* @see Page#encodedResponseToken()
*/
static PageToken build(
- @Nullable String serializedPageToken, @Nullable Integer
requestedPageSize) {
- return PageTokenUtil.decodePageRequest(serializedPageToken,
requestedPageSize);
+ @Nullable String serializedPageToken,
+ @Nullable Integer requestedPageSize,
+ Supplier<Boolean> shouldDecodeToken) {
Review Comment:
Hm, neither `getResolvedCatalogEntity` nor `getConfig` are really simple.
Mind making this at least a `Predicate`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
