snazy commented on code in PR #2406: URL: https://github.com/apache/polaris/pull/2406#discussion_r2287652019
########## CHANGELOG.md: ########## @@ -41,12 +51,32 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti - Added Catalog configuration for S3 and STS endpoints. This also allows using non-AWS S3 implementations. - The `IMPLICIT` authentication type enables users to create federated catalogs without explicitly -providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, -the authentication parameters are picked from the environment or configuration files. +providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, +the authentication parameters are picked from the environment or configuration files. - The `DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` feature was added to support placing tables at locations that better optimize for object storage. +- Added support for generic table `baseLocation` field in both server and client implementations. + +- Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems. + +- Added MinIO integration support with comprehensive getting started documentation. + +- Enhanced Python client with integration tests and improved error handling. + +- Added ability to override active roles provider configuration per realm for more flexible authentication setups. Review Comment: I think this one should be omitted, see #2404 ########## CHANGELOG.md: ########## @@ -41,12 +51,32 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti - Added Catalog configuration for S3 and STS endpoints. This also allows using non-AWS S3 implementations. - The `IMPLICIT` authentication type enables users to create federated catalogs without explicitly -providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, -the authentication parameters are picked from the environment or configuration files. +providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, +the authentication parameters are picked from the environment or configuration files. - The `DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` feature was added to support placing tables at locations that better optimize for object storage. +- Added support for generic table `baseLocation` field in both server and client implementations. + +- Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems. + +- Added MinIO integration support with comprehensive getting started documentation. + +- Enhanced Python client with integration tests and improved error handling. Review Comment: Should be in "highlights", not "breaking changes". ########## CHANGELOG.md: ########## @@ -41,12 +51,32 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti - Added Catalog configuration for S3 and STS endpoints. This also allows using non-AWS S3 implementations. - The `IMPLICIT` authentication type enables users to create federated catalogs without explicitly -providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, -the authentication parameters are picked from the environment or configuration files. +providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, +the authentication parameters are picked from the environment or configuration files. - The `DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` feature was added to support placing tables at locations that better optimize for object storage. +- Added support for generic table `baseLocation` field in both server and client implementations. + +- Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems. + +- Added MinIO integration support with comprehensive getting started documentation. + +- Enhanced Python client with integration tests and improved error handling. + +- Added ability to override active roles provider configuration per realm for more flexible authentication setups. + +- Introduced extensible pagination token implementation for better API performance. + +- Added support for `s3a` scheme in addition to existing S3 schemes. + +- Enhanced Helm chart with support for external authentication configuration and relational JDBC backend options. + +- Added comprehensive diagnostics and monitoring capabilities throughout the system. + +- Introduced bootstrap command options to specify custom schema files for database initialization. Review Comment: Should be in "highlights", not "breaking changes". ########## CHANGELOG.md: ########## @@ -29,6 +29,16 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti ### Highlights +- **HMS Federation Support**: Added support for Hive Metastore (HMS) federation, enabling integration with existing Hive metastores. + +- **Generic Table Federation**: Introduced modularized federation architecture to support multiple catalog types and improve extensibility. Review Comment: ```suggestion - **Modularized Federation**: Introduced modularized federation architecture to support multiple catalog types and improve extensibility. ``` (It's not about "generic tables", misleading) ########## CHANGELOG.md: ########## @@ -41,12 +51,32 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti - Added Catalog configuration for S3 and STS endpoints. This also allows using non-AWS S3 implementations. - The `IMPLICIT` authentication type enables users to create federated catalogs without explicitly -providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, -the authentication parameters are picked from the environment or configuration files. +providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, +the authentication parameters are picked from the environment or configuration files. - The `DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` feature was added to support placing tables at locations that better optimize for object storage. +- Added support for generic table `baseLocation` field in both server and client implementations. + +- Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems. + +- Added MinIO integration support with comprehensive getting started documentation. + +- Enhanced Python client with integration tests and improved error handling. + +- Added ability to override active roles provider configuration per realm for more flexible authentication setups. + +- Introduced extensible pagination token implementation for better API performance. + +- Added support for `s3a` scheme in addition to existing S3 schemes. + +- Enhanced Helm chart with support for external authentication configuration and relational JDBC backend options. + +- Added comprehensive diagnostics and monitoring capabilities throughout the system. Review Comment: Breaking? ########## CHANGELOG.md: ########## @@ -41,12 +51,32 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti - Added Catalog configuration for S3 and STS endpoints. This also allows using non-AWS S3 implementations. - The `IMPLICIT` authentication type enables users to create federated catalogs without explicitly -providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, -the authentication parameters are picked from the environment or configuration files. +providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, +the authentication parameters are picked from the environment or configuration files. - The `DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` feature was added to support placing tables at locations that better optimize for object storage. +- Added support for generic table `baseLocation` field in both server and client implementations. Review Comment: Not sure about this one. The feature is still experimental. ########## CHANGELOG.md: ########## @@ -41,12 +51,32 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti - Added Catalog configuration for S3 and STS endpoints. This also allows using non-AWS S3 implementations. - The `IMPLICIT` authentication type enables users to create federated catalogs without explicitly -providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, -the authentication parameters are picked from the environment or configuration files. +providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, +the authentication parameters are picked from the environment or configuration files. - The `DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` feature was added to support placing tables at locations that better optimize for object storage. +- Added support for generic table `baseLocation` field in both server and client implementations. + +- Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems. + +- Added MinIO integration support with comprehensive getting started documentation. + +- Enhanced Python client with integration tests and improved error handling. + +- Added ability to override active roles provider configuration per realm for more flexible authentication setups. + +- Introduced extensible pagination token implementation for better API performance. + +- Added support for `s3a` scheme in addition to existing S3 schemes. + +- Enhanced Helm chart with support for external authentication configuration and relational JDBC backend options. Review Comment: Should be in "highlights", not "breaking changes". ########## CHANGELOG.md: ########## @@ -41,12 +51,32 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti - Added Catalog configuration for S3 and STS endpoints. This also allows using non-AWS S3 implementations. - The `IMPLICIT` authentication type enables users to create federated catalogs without explicitly -providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, -the authentication parameters are picked from the environment or configuration files. +providing authentication parameters to Polaris. When the authentication type is set to `IMPLICIT`, +the authentication parameters are picked from the environment or configuration files. - The `DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` feature was added to support placing tables at locations that better optimize for object storage. Review Comment: Those (already present) should be in "highlights", not "breaking changes". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
