dennishuo commented on code in PR #2290:
URL: https://github.com/apache/polaris/pull/2290#discussion_r2286733181
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -129,6 +130,43 @@ ListEntitiesResult listEntities(
@Nonnull PolarisEntitySubType entitySubType,
@Nonnull PageToken pageToken);
+ /**
+ * Load entities with pagination
Review Comment:
Let's expand this javadoc description just a bit to make it more obvious
that this method is effectively a "list and load entities under a parent", and
maybe include some statement pointing at `{@link #listEntities}` to make the
intention clear of making this listing/pagination behavior here match that of
`listEntities`.
Michael's mention of future additions of `loadEntitiesById` and
`loadEntitiesByName` had just reminded me that the naming could feel ambiguous,
so javadocs can save developers time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
