XN137 commented on code in PR #2381:
URL: https://github.com/apache/polaris/pull/2381#discussion_r2284130968
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##########
@@ -93,6 +93,7 @@ public class TransactionalMetaStoreManagerImpl extends
BaseMetaStoreManager {
private final PolarisDiagnostics diagnostics;
public TransactionalMetaStoreManagerImpl(Clock clock, PolarisDiagnostics
diagnostics) {
+ super(diagnostics);
Review Comment:
how to handle this case?
in https://github.com/apache/polaris/pull/2372 @dimas-b suggested to make
fields in the base class private and have a protected getter...
when we do this in this file as well, we need to adjust 49 usage spots of
the field.
is it worth it for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
