dimas-b commented on code in PR #2372:
URL: https://github.com/apache/polaris/pull/2372#discussion_r2283077239
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java:
##########
@@ -51,6 +52,13 @@
* the BasePersistence methods in terms of lower-level methods that subclasses
must implement.
*/
public abstract class AbstractTransactionalPersistence implements
TransactionalPersistence {
+
+ protected final PolarisDiagnostics diagnostics;
Review Comment:
I'd prefer a `private` fields with a `protected` accessor. Direct field
access complicates debugging and code analysis. Also, this class is likely to
be reused downstream, which makes accessors more relevant, IMHO. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
