dimas-b commented on code in PR #2190:
URL: https://github.com/apache/polaris/pull/2190#discussion_r2277933579
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -173,6 +194,15 @@ public static ConnectionConfigInfoDpo
fromConnectionConfigInfoModelWithSecrets(
return config;
}
+ /**
+ * Creates a new copy of the ConnectionConfigInfoDpo with the given service
identity info.
+ *
+ * @param serviceIdentityInfo The service identity info to set.
+ * @return A new copy of the ConnectionConfigInfoDpo with the given service
identity info.
+ */
+ public abstract ConnectionConfigInfoDpo withServiceIdentity(
Review Comment:
Ok, if it's used in part 3, it's ok to keep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
