sfc-gh-pnilangekar commented on code in PR #2332:
URL: https://github.com/apache/polaris/pull/2332#discussion_r2277166313
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionType.java:
##########
@@ -35,6 +35,9 @@ public enum ConnectionType {
HADOOP(2),
;
+ public static final String ICEBERG_REST_FACTORY_IDENTIFIER = "ICEBERG_REST";
+ public static final String HADOOP_FACTORY_IDENTIFIER = "HADOOP";
Review Comment:
We still need these because we can't use
`ConnnectionType.ICEBERG_REST.name()` or `ConnectionType.HADOOP.name()`. The
annotations needs to be constant expressions. Here's the error for your
reference.
The value for annotation attribute Identifier.value must be a constant
expressionJava(536871525)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
