XN137 commented on code in PR #2320:
URL: https://github.com/apache/polaris/pull/2320#discussion_r2272797700
##########
polaris-core/build.gradle.kts:
##########
@@ -43,10 +43,9 @@ dependencies {
implementation(libs.caffeine)
implementation(libs.commons.lang3)
- implementation(libs.commons.codec1)
+ implementation(libs.commons.codec)
Review Comment:
i assume you mean removing it? commons-codec is used in multiple places in
the codebase so that doesnt seem possible:
```
git grep 'org.apache.commons.codec'
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrincipalSecrets.java:import
org.apache.commons.codec.digest.DigestUtils;
polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java:import
org.apache.commons.codec.digest.DigestUtils;
runtime/service/src/main/java/org/apache/polaris/service/auth/DefaultOAuth2ApiService.java:import
org.apache.commons.codec.binary.Base64;
runtime/service/src/main/java/org/apache/polaris/service/http/IcebergHttpUtil.java:import
org.apache.commons.codec.digest.DigestUtils;
runtime/service/src/main/java/org/apache/polaris/service/task/ManifestFileCleanupTaskHandler.java:import
org.apache.commons.codec.binary.Base64;
runtime/service/src/main/java/org/apache/polaris/service/task/TaskUtils.java:import
org.apache.commons.codec.binary.Base64;
runtime/service/src/test/java/org/apache/polaris/service/task/ManifestFileCleanupTaskHandlerTest.java:import
org.apache.commons.codec.binary.Base64;
runtime/service/src/test/java/org/apache/polaris/service/task/TableCleanupTaskHandlerTest.java:import
org.apache.commons.codec.binary.Base64;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
